undefined | Better HN

0 pointserickt8y ago0 comments

If I recall correctly we just couldn't come up with a great name for it. To me "expect" is a positive action, but the argument is about it failing to meet the expectation. Semantically I like `thing.unwrap_or(|| panic!("failure message"))`. It feels more like what I would want to say, but it just is so wordy.

Ultimately I'm happy we just picked something and moved on, but still mildly annoys me whenever I write it. If only we found that perfect method name way back when...

0 comments

Double_Cast8y ago

  .beware("could not open file");

tomjakubowski8y ago

    .be_wary_of("but hole")

AlphaSite8y ago

The java optional api uses orElseThrow which I think is quite clear.

bluejekyll8y ago

Agreed, I've never liked 'expect' either; 'or_else_panic(msg)' would be much clearer

Edit: 'or_panic(msg)' would be shorter and also good.

ericktOP8y ago

I think that was one of the proposed variations, but we ended up picking the shorter .expect to cut down on repetition. We expected (ha) that this function would be used in these one-offs, so we wanted something more efficient.

1 more reply

e12e8y ago

otherwise(msg)?

1 more reply

AsyncAwait8y ago

It is, but also quite long, which I do not think suits Rust naming conventions.

bluejekyll8y ago

Not really though: 'unwrap_or_else' is of similar length.

j / k navigate · click thread line to collapse

0 pointserickt8y ago0 comments

Ultimately I'm happy we just picked something and moved on, but still mildly annoys me whenever I write it. If only we found that perfect method name way back when...