undefined | Better HN

0 pointsbijection8y ago0 comments

To make that work for all elements of that class, you could rewrite it as

  document.querySelectorAll('.myclass')
    .forEach(el => el.style.display = 'block')

The jQuery is still shorter, but the vanilla js is definitely manageable.

0 comments

tracker18y ago

  Array.from(document.querySelectorAll('.myclass'))
    .forEach(el => el.style.display = 'block')

collinmanderson8y ago

Though ie11 doesn't have Array.from()

bonesss8y ago

Hrmmm... maybe someone should make a library that would smooth over browser differences and provide a consistent element selection syntax? Call it JavascriptSelection, or jSelection?

1 more reply

tracker18y ago

I tend to polyfill older browsers, Array.from is a pretty small one. Sad thing is at a point where it's probably worth it to have 2-3 builds in place... 1 for legacy browsers, one for modern without modules, and one for modules/import/http2 support.

Just haven't taken the time... at least the main app I work on at work doesn't need to support IE11. Latest Edge,, Firefox, Safari and Chrome ... and Chrome is the primary target.

no_gravity8y ago

Unfortunately, querySelectorAll returns a NodeList, not an Array. So you cannot use forEach() on it.

hawkice8y ago

NodeList also implements forEach:

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/fo...

collinmanderson8y ago

It's a very recent addition. IE11 doesn't have it for sure.

no_gravity8y ago

Not in Edge though.

1 more reply

j / k navigate · click thread line to collapse

0 pointsbijection8y ago0 comments

To make that work for all elements of that class, you could rewrite it as

  document.querySelectorAll('.myclass')
    .forEach(el => el.style.display = 'block')

The jQuery is still shorter, but the vanilla js is definitely manageable.

0 comments

tracker18y ago

  Array.from(document.querySelectorAll('.myclass'))
    .forEach(el => el.style.display = 'block')

collinmanderson8y ago

Though ie11 doesn't have Array.from()

bonesss8y ago

Hrmmm... maybe someone should make a library that would smooth over browser differences and provide a consistent element selection syntax? Call it JavascriptSelection, or jSelection?

1 more reply

tracker18y ago

Just haven't taken the time... at least the main app I work on at work doesn't need to support IE11. Latest Edge,, Firefox, Safari and Chrome ... and Chrome is the primary target.

no_gravity8y ago

Unfortunately, querySelectorAll returns a NodeList, not an Array. So you cannot use forEach() on it.

hawkice8y ago

NodeList also implements forEach:

https://developer.mozilla.org/en-US/docs/Web/API/NodeList/fo...

collinmanderson8y ago

It's a very recent addition. IE11 doesn't have it for sure.

no_gravity8y ago

Not in Edge though.

1 more reply

j / k navigate · click thread line to collapse