People were annoyed because they don't want to run a different OS. Yes, you could get cheaper/powerful hardware somewhere else... but it's not macOS. Hackintoshes need not apply here.
Thing is, Mac OS isn't as great as it used to be either. They used to be brilliant developer laptops, but Apple seems to want everybody in their walled garden.
My summarized conclusion is that: OS X isn't that great. It's not "bad," don't get me wrong, but it's nothing marvelous. Perhaps at one point in time there was some advantage over a Windows or linux environment but at this point in time, unless you're tied to some package tied to a specific environment for some reason, just work with the environment you're most comfortable with. I don't know how much time I've had to waste adjusting to the OS X environment (especially muscle memory keyboard shortcuts I'm accustomed to), finding replacement niche applications that were environment specific, figuring out how to do basic tasks that are simply different.
On that note, avoid committing to a specific environment unless your application really needs to squeeze out every cycle of performance. It's 2019 and we have portable options now for most application demands.
There were other things (good-enough port selection complementing the high battery life and good trackpad to mean I could just grab my laptop and go for nearly any situation, without taking anything else, being high among them) but they're gone now. It's basically the software and the trackpad keeping me around. I'd rather use a "worse" Macbook specs-wise than a Win10 or Linux laptop that's much better on paper, because the experience will still suck far less. Design, "thinness", trendiness, all that, don't give a shit. Give me a brick of a Thinkpad with an Apple trackpad, official macOS support, and a 20% lower price than a MBP at same specs, and I'll take that option in a heartbeat.
would you agree with this change to your description?:
"Yes, you could get [better] hardware somewhere else..."
If it's just about running MacOS, they absolutely apply.
There are nothing else making the macbook lines worth it. If Linux with hardware manufacturer come up with a standard for greater touchbar control, the mac will be out of circulation in no time.