undefined | Better HN

0 pointsodensc6y ago0 comments

In theory `x instanceof Promise` would work, but the reason for this package is that there are many non-standard Promise implementations in the JS world.

0 comments

exogen6y ago

It wouldn't work even if everything were native – see my reply above.

odenscOP6y ago

That applies for browsers, yes (though I'd argue is a rare edge-case), but create-react-app is a Node.js application.

exogen6y ago

create-react-app isn't even using is-promise directly. It's several hops in the dependency graph away.

j / k navigate · click thread line to collapse

0 comments

exogen6y ago

It wouldn't work even if everything were native – see my reply above.

odenscOP6y ago

That applies for browsers, yes (though I'd argue is a rare edge-case), but create-react-app is a Node.js application.

exogen6y ago

create-react-app isn't even using is-promise directly. It's several hops in the dependency graph away.

j / k navigate · click thread line to collapse