It has worked for me perfectly for quite a long time. All my personal documents and photos are synced between an Android phone, my RPi 4 and my laptop. I haven't touched the settings for years. It just always works, 100% perfectly. I don't understand why it isn't more popular.
I managed to get syncthing running well in my rpi4 but the sync was just abysmally slow. I'm on gigabit internet however the time delay between syncing and then syncing itself was slow. I think it is more to do with a delay in handshake or device discovery than the transmission of data itself. Any tips for making the discovery better/faster?
"First, you'll want to set up a server" and you're already down to well under 1% of the population that'll be interested in reading any further, let alone following through and actually doing it.
I doubt the OP intended to ask why it wasn't popular among the general population. That seems obvious. I would interpret his question as asking why it's not more popular even among the subset of people who are happy to run their own servers, like readers of this very board.