1. a python filtering function I wrote 2. how to restructure an entire django project.
Both (esp #2) are a little big for posting a code snippet. Bigger architecture problems probably only make sense within the context of the larger scope, so I'd pretty much want someone to check out the whole repository.
The SO thing would be great because SO has built in reputations so it'd help people feel more comfortable with giving away the entire project. I personally don't care, but I can imagine that being a barrier to code reviews by strangers.
Obviously, that sort of code review is a much more time-expensive request, so finding reviewers might also be hard without some sort of compensation.
similar idea.
The trick is, could there be some sort of bilateral confidentially agreement? That's one I'd need to ponder a bit.
Mostly, if I cared about confidentiality, it'd be so I don't get publicly embarassed for crappy code.
Rating systems for reviewers would also let people build reputations so that reviewee's could feel more comfortable about code confidentiality.
Stack overflow already has reputations built in, so as I mentioned, it might just be awesome as a feature for SO. And another revenue stream, if they weren't already swimming in cash.
Whilst sharing it with someone you could refer to as a colleague, employee, or contractor might be OK. Sharing it with the world, or someone who might share it with the world, is not.
You can review and give decent feedback on a small snippet of code fairly easily and quickly, but that's of limited value in a real project.
To be able to give a decent review (eg beyond a cursory "You should name that variable better, or your indentation sucks), requires that either the amount of code you are reviewing is so small that you can grok it quickly (limiting the value of the review), or that you spend at least some time familiarizing yourself with the rest of the code base so be able to gauge the impact of the code changes.
This is all good if the person you're trading reviews is prepared to spend the same amount of time on your code, but for example, I find it very frustrating when I spend 30-45 minutes giving a detailed review of a website on http://feedbackroulette.com (a similar concept, but for websites reviews), only to get back a 3 sentence review in exchange that was clearly bashed off in about 30 seconds. Awarding points for reviews goes someway to alleviate this, but still it's a real pita...
(aside: I can't actually work out if people who complete reviews at 5 sec tests get paid? Or if they do just get karma)
If anyone has some bitcoins and wants a code review, send me an email: omouse@gmail.com
