undefined | Better HN

0 pointsjshen4y ago0 comments

Here you go. Took me about 15 minutes to write, using < 50 lines of code, and not using any external libraries outside of the Go Project. The 15 minutes includes the time to create the server I used to test it.

https://gist.github.com/jaydonnell/4fd14c69132734aac76b7f538...

0 comments

valenterry4y ago

Very cool! I'll let my solution follow soon.

Immediate question that I have (since I can't execute it easily):

What happens if we have 11 requests, each request takes 1 second to be responded to, but one of the first 5 requests fails 3 times and each time the reponse until failure takes 0.1 seconds.

Will all 10 successful requests be completed within 2 seconds then? Or will the failing request block the 11th requests for 0.3 seconds, meaning that all 10 successful requests will only be completed within 2.3 seconds?

jshenOP4y ago

I’m limiting it to 5 concurrent requests which is independent of the rate limit itself. The failing request will hold one of those 5 slots until all 3 failures are done, but won’t otherwise block anything.

valenterry4y ago

I have matched this implementation, here's my approach:

https://scastie.scala-lang.org/AiusSr76QLCTrlZvBICT7A

13 lines and should behave like yours (i.e. is not optimal in the sense of fully utilizing the rate limit).

Curious to see your solution that fully utilizes the rate limit - it's not so trivial I think. :)

Anyways. I have to say that the Go-code is better than I expected (even for the suboptimal solution). But given my experience with higher abstractions (here streaming) I personally find the streaming solution much more readible.

1 more reply

valenterry4y ago

Which means the solution isn't really optimal, since if every second request fails, the code won't take full advantage of the rate limit and only do 2.5 successful requests per second.

1 more reply

j / k navigate · click thread line to collapse

0 comments

valenterry4y ago

Very cool! I'll let my solution follow soon.

Immediate question that I have (since I can't execute it easily):

What happens if we have 11 requests, each request takes 1 second to be responded to, but one of the first 5 requests fails 3 times and each time the reponse until failure takes 0.1 seconds.

jshenOP4y ago

valenterry4y ago

I have matched this implementation, here's my approach:

https://scastie.scala-lang.org/AiusSr76QLCTrlZvBICT7A

13 lines and should behave like yours (i.e. is not optimal in the sense of fully utilizing the rate limit).

Curious to see your solution that fully utilizes the rate limit - it's not so trivial I think. :)

1 more reply

valenterry4y ago

Which means the solution isn't really optimal, since if every second request fails, the code won't take full advantage of the rate limit and only do 2.5 successful requests per second.

1 more reply

j / k navigate · click thread line to collapse