I think what will hurt them in the long run is their pattern of user-hostility will start to affect their image. For instance:
* Right to repair gaining steam (Apple now introducing some basic form of parts availability)
* Apple eroding their image as a Privacy company (Apple had to delay their "child safety" tools after public outcry)
* iMessage lock-in (Apple users "bullying" Android users due to Apple's hostile UI choices).
Those are just the recent examples that come to mind.
It'll all add up until Apple has a PR problem that actually does start affecting their bottom line, and then they'll have to make concessions that'll make people happy again.
However, my 6 was proper dying, so once they bought out the SE or whatever with a sensible form factor and fingerprint scanner I was convinced it was better than trying to switch
