These are the two most fundamental features of a PR. How could they decide so few as 10 is the right number of comments?
This. Every PR I have to do ctrl-F "load diff" and then immediately click on _all_ of the diffs. It's !@#$ing annoying.
I've also lost comments when the comment is part of a review and pushed to the PR after the the PR has been merged by someone else.
[0] https://github.com/refined-github/refined-github
[1] https://github.com/refined-github/refined-github/issues/2151
I think the evidence is pretty clear that the most effective development process for large codebases is to look at changes as effectively a series of patches applied to head-of-trunk (and those patches may evolve during review)... and github seems to almost go out of its way to prevent you from thinking about PRs as if they were patches.
Unfortunately there are a massive number of codebases where a "simple" change can mean changing _lots_ of places.
In the screenshot in the post it looks like the navigation tree is crammed into the 1280px wide grid, but that's not the case - enabling the feature preview makes the page full-width. So it doesn't make the diff area unreadable.
Link for people who didn’t know about this feature: https://mobile.twitter.com/github/status/1425505817827151872 and the official documentation with other keyboard shortcuts: https://docs.github.com/en/get-started/using-github/keyboard...
Though relatively late, I am glad it's coming to Github, more people can benefit from this kind of pull request presentation.
We've had a file tree for some time now (along with some of the other feedback I'm seeing in this thread, large diffs etc).
If anyone wants to give it a spin, happy to give you an invite :)
Not sure how long it’s been in AzureDevOps but it could have been inspired from GitLab there I suppose.
Side-note: I took a look at the ‘About’ page thinking ‘Hey, they said ex-FB, extremely unlikely but maybe i know someone’. Looking at your username I’m guessing you’re jacob gold and worked on messaging infra in NY. I used to work on Iris! Small world.
Also, I hate repos that convert issues to discussions. Might as well close the issue, as discussion is usually a graveyard.
'Moved to discussion' seems better to me than 'closed; tagged question'.
That’s why they do it, but what they’re doing is essentially rejecting the request. If it’s a question, sure, but if it’s a feature request or worse yet a bug report then moving to discussions is bs.
I don’t like scrolling until I see “holy cow wat”.
