undefined | Better HN

0 pointsSamuelAdams3y ago0 comments

Do you not have internal coding standards / guidelines? Ideally this is what a PR process is for - reviewing new code and making sure it adheres to the team’s expectations.

If code is not where you want it to be, reject the PR, leave specific comments about what was done well and what was done poorly, then repeat the cycle until code is where you need it to be.

0 comments

tharkun__3y ago

I don't know why you mention this in reply to my comment. I don't see how this is related.

Now with that said, of course we have standards. That's the bar ;)

The point I was making is that it seems that the average developer is so far below the bar, that I don't want to hire average developers.

Of course there are some juniors (and even some seniors) that will take to code review comments, pairing with them, mentoring them, giving feedback etc. and will improve. Many many don't. Like mentioned elsewhere in the threads here, I think at least some of that has to do with the fact that so many developers have entered the market but they actually aren't good at it. They're in it for the money. They pull the average so far down that hiring average developers is excruciatingly frustrating.

j / k navigate · click thread line to collapse