undefined | Better HN

0 pointsegeozcan2y ago0 comments

I was looking at the datagrid. I can't use the menus with the keyboard. I can't select columns. I can't see the currently focused element. My screen reader does not inform me of the menus, nor can I interact with them. Inputs have outline: none. Labels are not connected to the inputs.

In this example: https://perspective.finos.org/block/?example=superstore

I can't use the tree with the keyboard. From the patterns page I linked, you can see an implementation example for an accessible tree element.

I mean, I can continue. I'm not saying this to devalue your work, and I wish I had the time to go in depth and analyze all the components and give you more feedback, but I don't. So I humbly suggest you do a bit research about the topic and improve the product some.

Perhaps my original comment sounded too dismissive and therefore got many negative feedback, but I'm sincerely concerned. I wanted to hint at this as this is a tool that may be used by businesses and some people cannot do their job because of inaccessible tooling.

I do like what you are doing and the components do look cool - nothing to take away from that. Please take my comment as constructive as you can take it to be because I was trying to go for that, and perhaps my frustration in the last few years with this topic made me also whine a little bit :)

0 comments

texodus2y ago

Like I said - GitHub is the preferred method of reporting issues:

* Some of these (keyboard nav, focus) we test for and sounds like a specific issue with your browser/OS setup, which we'd very much like to fix. GitHub Issues allow us to ask these followup context questions.

* Some of these are vague, I'm not aware of any label+input in the component, e.g., nor how column selection is related to accessibility. The venue for this discovery is GitHub Issues - just because they are obvious to you does not make them obvious to us such that RTFM is a suitable correction, humbly or otherwise.

The project has relatively wide financial industry usage (and some of the code was originally developed at JPMC), and we're very interested in fixing real issues!

egeozcanOP2y ago

Well, I'm sorry, I can only help so much. I also try to open source many things as I can, and I'm active on Github in many projects but I have only so much time.

> Some of these (keyboard nav, focus) we test for and sounds like a specific issue with your browser/OS setup

It's probably not (tried on another computer and browser). Please open this page: https://perspective.finos.org/blocks/superstore/index.html Try to navigate with your keyboard. There are no outlines and the tree view is not possible to interact with.

> I'm not aware of any label+input in the component

The top and right toolbars here: https://perspective.finos.org/blocks/editable/index.html Are the not the part of the component? Perhaps I'm mistaken to think so. My apologies if they aren't.

> how column selection is related to accessibility

https://developer.mozilla.org/en-US/docs/Web/Accessibility/A...

The column headers aren't possible to interact with a keyboard anyway, and the screen reader doesn't announce anything to indicate that the table can be sorted.

In my current job, we paid a lot of money for an army of auditors to hunt these down for us, and I don't expect that you do something like that for an open-source product, but if you have corporate use (I mean if people are paying for this directly or indirectly, and I hope they do!), maybe it makes sense to go for one?

j / k navigate · click thread line to collapse