undefined | Better HN

0 pointsbiorach2y ago0 comments

Still... did no one with even moderate Python experience even glance at this very important endpoint at any stage during those 4 weeks? Like I say, this is the kind of thing that jumps out of the screen for an experienced developer.

0 comments

Macha2y ago

In 2010? You'd be surprised before widespread adoption of git at how many places the process was individual developers committing changes unsupervised. I'm not sure we even disagree that's the problem - you feel a second person should have looked at it, I feel the process should require that. A code review might be something that they'd sit down with a selected piece of code that they felt was risky on a biweekly basis or something.

godzillabrennus2y ago

I’m 2010 access to prod over ftp:// might have still been a thing even at digg.

biorachOP2y ago

Forget code review. This is one of their most important endpoints. They had severe issues for 4 weeks. Did no one not even glance over the code and spot this glaring screw-up?

0xAFFFF2y ago

Considering the context, most people were probably overloaded with work and a lot of changes must have been made with little to no oversight.

j / k navigate · click thread line to collapse