While we're on the subject of Rails security, should this be of concern? (opens in new tab)

(github.com)

24 pointsrubypay14y ago12 comments

12 comments

I presume this is not strictly a Rails problem.

You can check in things that shouldn't be checked in with any language/framework.

If you have done this, here's how to fix it: http://help.github.com/remove-sensitive-data/

Better is to change your security token and expire all sessions. Removing sensitive data should be seen as just a suggestion. Google never forgets.

antics14y ago

Before we all grab our pitchforks, I have just gone through the entire first page of results and a huge majority of them were explicitly noted as test applications. Sometimes you can see this in the names:

    test / rails_app_v3 /
    test_app / config

In many other instances, things are not as the seem. For example, some of these results come from commits where the author is moving the token to an environment variable. For example: https://github.com/cimm/blathy/blob/2d3a9550d3a0be55db8e26a2...

I certainly agree that we should all be security conscious, but I'm also a fan of keeping perspective. Things are bad, but let's keep the truth in mind too.

TazeTSchnitzel14y ago

Also, for the ones that were not test apps, they may be the testing/development secret keys which are different from the production secret keys. I do this myself, where the hash salt and API keys for my local development server are different from those I use on my production server.

5h14y ago

Not just rails, same for django (https://github.com/search?q=SECRET_KEY&repo=&langOve...) and I imagine any framework with this sort of thing in their default project skeleton

justindocanto14y ago

This is not a language/framework based issue. This is an issue with careless and/or uneducated developers.

This is like people storing plain text passwords in publicly readable txt files on a server. It's not a problem with FTP, HTML, Apache (pick anything you'd like) it's a problem with people making poor decisions.

bradleyland14y ago

Flagged. This is just ridiculous. I actually support Egor, but this borders on absurd. The question is stated incorrectly. The actual question is:

"Is storing your private key in a public repository a security concern?"

It's a parody of a security question. This is a needless distraction in an important discussion.

oscardelben14y ago

Could this help? https://github.com/rails/rails/pull/5286

manojlds14y ago

Soon, there will be articles on how insecure Git is because, well, it allows people to check-in sensitive stuff.

yuvadam14y ago

Not really. At least not in the way you are insinuating.

zbuc14y ago

Facebook as well...

https://github.com/search?q=FB_SECRET&repo=&langOver...

Not really a "vulnerability" because you can't keep stupid people from giving out their secret key.

AznHisoka14y ago

The solution is simple. Don't use a secret token :)

j / k navigate · click thread line to collapse