undefined | Better HN

0 pointsnicoburns2y ago0 comments

> If you cut it out and move everything to parameterized SQL queries the SLOC explodes

My experience has been the opposite: that raw SQL queries end up much shorter (and consequently more readable) than the equivalent ORM code. The exception to that is INSERT/UPDATE queries, where I do tend to use some kind of ORM/query builder. I have used both, and I prefer raw SQL for anything beyond very simple queries.

0 comments

pydry2y ago

I have never seen an ORM in my life that didn't reduce the total amount of code written. Not even the Java monstrosities increased the SLOC.

nicoburnsOP2y ago

Perhaps it depends what you're doing?

IMO:

    .where('column_a', '=', 'value1')
    .and(q => q.isNull('column_b').orWhere('column_b', '=', 'value2')))

is a lot less readable than:

    WHERE
       column_a = 'value1'
       AND (column_b IS NULL OR column_b = 'value2')

DangitBobby2y ago

In Django that would be .filter(column_a='value1', Q(column_b__isnull=True)|Q(column_b='value2'))

And obviously you can use whatever indentations you like.

nicoburnsOP2y ago

Ah, that's quite a bit nicer. You can't do that in JavaScript on two counts:

- No keyword arguments

- No operator overloading (so you can't override | to get the nice "or" syntax)

1 more reply

LinXitoW2y ago

One of these my IDE can typecheck and apply code hightlighting, the other is just a blob of text.

pjmlp2y ago

On my case that would be SQL, as I use nice SQL aware IDEs for Oracle and SQL Server.

Izkata2y ago

Separate chain for a different Django example, it only natively supports joins on explicit foreign keys, but because it has that extra information in the model the syntax for using it is extremely compressed. Let's say you have a "Dog" table with a foreign key to "Owner", and "Owner" has a foreign key to "City". Getting all the dogs that live in New York would be:

   Dog.objects.filter(owner__city__name = 'New York')

The double-underscore follows the foreign keys until the last one, which is a field on the last model.

j / k navigate · click thread line to collapse

0 comments

pydry2y ago

I have never seen an ORM in my life that didn't reduce the total amount of code written. Not even the Java monstrosities increased the SLOC.

nicoburnsOP2y ago

Perhaps it depends what you're doing?

IMO:

    .where('column_a', '=', 'value1')
    .and(q => q.isNull('column_b').orWhere('column_b', '=', 'value2')))

is a lot less readable than:

    WHERE
       column_a = 'value1'
       AND (column_b IS NULL OR column_b = 'value2')

DangitBobby2y ago

In Django that would be .filter(column_a='value1', Q(column_b__isnull=True)|Q(column_b='value2'))

And obviously you can use whatever indentations you like.

nicoburnsOP2y ago

Ah, that's quite a bit nicer. You can't do that in JavaScript on two counts:

- No keyword arguments

- No operator overloading (so you can't override | to get the nice "or" syntax)

1 more reply

LinXitoW2y ago

One of these my IDE can typecheck and apply code hightlighting, the other is just a blob of text.

pjmlp2y ago

On my case that would be SQL, as I use nice SQL aware IDEs for Oracle and SQL Server.

Izkata2y ago

   Dog.objects.filter(owner__city__name = 'New York')

The double-underscore follows the foreign keys until the last one, which is a field on the last model.

j / k navigate · click thread line to collapse