You're right that the save is going to vanish from the batteries, but tests and anecdata have shown that cartridge batteries on Game Boy can easily last more than three decades.
Pokémon Silver, Gold, and Crystal have a clock inside the cartridge, limiting their survivability to around a decade.
