undefined | Better HN

0 pointsnightpool1y ago0 comments

I mean, it's explained very clearly in the commit message that's linked?

    Since the page where the bug manifests itself already has responsive CSS
    styling, we can quirk TextAutoSizing to skip adjusting for it, at least
    until we figure out why we are calculating RenderBlockFlow width inconsistently:
    https://bugs.webkit.org/show_bug.cgi?id=275223

That's even better than a comment, because you can git blame for it and get the full context of the issue (from the bug thread that proposed it to all of the documentation of the investigation done for both bugs)

0 comments

freedomben1y ago

I very much disagree that it's better than a comment. The git blame log will over time get layered on as changes are made to various lines, meaning you have to dive for the original message, assuming one is even there (many a time I dig for commits, only to see that the commit message doesn't answer the question of motivation very well or at all). A short comment in the code makes it obvious.

j / k navigate · click thread line to collapse

0 pointsnightpool1y ago0 comments

I mean, it's explained very clearly in the commit message that's linked?

    Since the page where the bug manifests itself already has responsive CSS
    styling, we can quirk TextAutoSizing to skip adjusting for it, at least
    until we figure out why we are calculating RenderBlockFlow width inconsistently:
    https://bugs.webkit.org/show_bug.cgi?id=275223

0 comments

freedomben1y ago

j / k navigate · click thread line to collapse