So while I agree with the GP's comment that Franklin didn't know anything about electrons, so he arbitrarily picked one as negative and the other as positive, now that we do know about the movement of electrons, it kinda sucks because I think Franklin just "picked wrong".

I.e. it would make much more sense to me if the absence of electrons (i.e. holes) were negative by convention and an abundance of electrons were denoted as positive.