“Terrorist” groups Irgun, Haganah, Lehi all became part of Israeli government and army post 1948. Israel has mandatory military service for its citizens.
Irgun and Lehi were both offshoots which can be categorized as terror organizations, however they were very small, with a few hundred members and never reached the size or level of support of any Palestinian organization
While the Haganah formed most of the IDF leadership, the new country civilian leadership was based on the Jewish Agency which predated the Haganah and had completely civilian leadership.
There are many other differences between Hamas and these organizations, but in general this is an invalid comparison
All three groups at times participated in violent activities targeting the British, Arabs, and even at times other Jews.
Haganah was proscribed by the British mandate and was an unlawful, underground militia. Lehi had 100s of members but Irgun had 4000-8000.
You yourself admit that Lehi and Irgun could be categorized as "terrorist" and Haganah engaged in what you describe as "something in between guerilla warfare and terror attacks".
The British certainly thought of all three as "terrorist" groups, which is why they targeted them with military and police action - https://israeled.org/british-round-up-resistance-fighters/
Hamas would also not describe themselves as "terrorist", they also describe themselves as a "resistance" movement.
Haganah both planned and executed the "Plan Dalet", which killed and forcibly expelled the vast majority of non-Jews from their lands - they actually did what people accuse Hamas of wanting to do.
Regarding Plan Dalet, saying that most of the non-jews were killed or forcibly expelled is simply not true, not chronologically or factually.
Fact is that most of the Palestinians in 1948 fled on their own accords, while forced expulsions happened they were rare and were done for military reasons, mostly preparing for the imminent attack of five regular armies, as happened by the other side as well (e.g. kfar etzion)
While Israel proper has a sizable Palestinian population that is larger than the population of the Gaza strip
