MacBooks tend to last a long time. I used my 2012 Macbook Air for 7-8 years easily. It's still working today. My M1 Pro 16" has had no issues at all for nearly 4 years. They’re extremely reliable (except butterfly era).
Personally, I don’t think Framework laptops are. I think they are only more environmentally if you upgrade your MacBook every year or every other year. I think this is extremely niche. Not only are you getting a laptop with much worse battery life, noise, heat, screen, build quality, you are also getting a significantly slower CPU and GPU. AMD and Intel chips simply can't keep up with Apple Silicon.