undefined | Better HN

0 pointsparennoob12y ago0 comments

These are the lines that make me think he is an asshole.

> Ben made a mistake by not understanding how important the gender pronoun change was in the pull request. But he was trying to interpret the commit rules...

WTF? Any commit should be according to commit rules. And changes which do not actually affect how the code runs are actually unimportant from a core committer's point of view. Couldn't Issac Roth have empathized with that worldview a little more?

> But people deserve a chance to correct their mistakes and improve.

"You enforced standard commit policy, but because the extreme feminists didn't like it, I am going to give you a chance before firing you."

...aaaand

> If Ben can’t learn, we’ll fire him. [Edit: See comment below. This is not meant literally.]

"If Ben can't learn, we will fire him. Don't worry, only figuratively fire him. Work out how we can figuratively fire him, good day!"

0 comments

shawndrost12y ago

"Any commit should be according to commit rules. And changes which do not actually affect how the code runs are actually unimportant from a core committer's point of view."

While it's actually hard to believe, I think the (very trivial) commit that was rejected broke the build for two reasons:

1) The project in question has a CLA requirement. https://github.com/joyent/libuv/blob/master/CONTRIBUTING.md#...

2) The project in question has a commit message policy that is CI-enforced. https://github.com/joyent/libuv/blob/master/CONTRIBUTING.md#...

Can anyone else confirm? I haven't seen this fact discussed publicly (although knowledgable people seem to allude to it).

j / k navigate · click thread line to collapse