undefined | Better HN

0 pointsentropy_12y ago0 comments

You don't need to force push at all. You could just apply the changes to your PR in a different branch(completely local, rewrite history as much as you want, etc, etc) and then submit a second PR with that.

0 comments

davexunit12y ago

A whole new PR? That just shows how broken PRs are if that's the solution to this problem.

jimktrains212y ago

It's _A_ solution, but not a good one. I think most people consider it OK to force-push a PR branch and update the existing pull request.

davexunit12y ago

There's a lot of opportunity for destruction with a force push, so it seems weird to consider it acceptable in a code review workflow.

j / k navigate · click thread line to collapse

0 comments

davexunit12y ago

A whole new PR? That just shows how broken PRs are if that's the solution to this problem.

jimktrains212y ago

It's _A_ solution, but not a good one. I think most people consider it OK to force-push a PR branch and update the existing pull request.

davexunit12y ago

There's a lot of opportunity for destruction with a force push, so it seems weird to consider it acceptable in a code review workflow.

j / k navigate · click thread line to collapse