undefined | Better HN

0 pointsremi11y ago0 comments

Actually, it does in a certain way. Travis runs builds (tests + Phare) for all pull requests (eg. https://travis-ci.org/mirego/encore/pull_requests) so we know if pull requests made by external contributors "break the build".

0 comments

nl587411y ago

Yes, true, but only if it breaks. This enforces common code quality issues, so it will run side-to-side with travis.

ayrx11y ago

In all my projects (and the projects I contribute to), style issues are a build-breaking defect.

In Python this usually means running flake8 as a Travis job.

j / k navigate · click thread line to collapse

0 pointsremi11y ago0 comments

0 comments

nl587411y ago

Yes, true, but only if it breaks. This enforces common code quality issues, so it will run side-to-side with travis.

ayrx11y ago

In all my projects (and the projects I contribute to), style issues are a build-breaking defect.

In Python this usually means running flake8 as a Travis job.

j / k navigate · click thread line to collapse