The Art of Code Review: A Dropbox Story (opens in new tab)

(objc.io)

46 pointsleahculver11y ago11 comments

11 comments

Also nice is the style guide, which also covers a number of best practices for modern Objective-C: https://dl.dropboxusercontent.com/s/5utnlwhr18ax05c/style-gu...

kelukelugames11y ago

Curious, has anyone adopted another company's published style guide?

spigoon11y ago

At Tilt we use the NY Times Objective-C styleguide. https://github.com/NYTimes/objective-c-style-guide

1 more reply

achompas11y ago

At Knewton we used (use?) Google's Python style guide.

bshimmin11y ago

I think this may very well be the most joyless article about software engineering I've ever read. The sort of weird tone of moderately enthused Newspeak is also quite frightening in a way.

rikkus11y ago

Initially I thought it seemed unreal, with the way it was written, then I thought perhaps it was satire, but couldn't work out what was funny about it.

"Bask in our engineer’s prideful feeling that every single line now being added to the Dropbox for iOS app began as a task in Maniphest."

I follow a system just like this; it keeps things working smoothly, but I'm not sure I'm basking in any kind of pride over it.

joeconway11y ago

Much more interesting in my opinion is the Square article also in this issue of objc.io http://www.objc.io/issue-22/square.html

I am surprised to not see that article on HN instead of this one.

drisco11y ago

Even though this might be best for the company and the product, does anyone else feel that big bureaucratic processes like this take away the joy and creativity of coding? I suppose it is because I'm more fond of coding as an art than as a science.

krazydad11y ago

Totally. While it seems appropriate that a product like Dropbox would require some very careful risk management and quality control, this feels like a joyless environment, despite the occasional use of memes in quality control threads.

krazydad11y ago

Thank god there's a few dank memes to offset the bitter taste of the mountain of red-tape. Employee morale must be off-the-charts!

j / k navigate · click thread line to collapse

11 comments

aston11y ago

Also nice is the style guide, which also covers a number of best practices for modern Objective-C: https://dl.dropboxusercontent.com/s/5utnlwhr18ax05c/style-gu...

kelukelugames11y ago

Curious, has anyone adopted another company's published style guide?

spigoon11y ago

At Tilt we use the NY Times Objective-C styleguide. https://github.com/NYTimes/objective-c-style-guide

1 more reply

achompas11y ago

At Knewton we used (use?) Google's Python style guide.

bshimmin11y ago

I think this may very well be the most joyless article about software engineering I've ever read. The sort of weird tone of moderately enthused Newspeak is also quite frightening in a way.

rikkus11y ago

Initially I thought it seemed unreal, with the way it was written, then I thought perhaps it was satire, but couldn't work out what was funny about it.

"Bask in our engineer’s prideful feeling that every single line now being added to the Dropbox for iOS app began as a task in Maniphest."

I follow a system just like this; it keeps things working smoothly, but I'm not sure I'm basking in any kind of pride over it.

joeconway11y ago

Much more interesting in my opinion is the Square article also in this issue of objc.io http://www.objc.io/issue-22/square.html

I am surprised to not see that article on HN instead of this one.

drisco11y ago

krazydad11y ago

Thank god there's a few dank memes to offset the bitter taste of the mountain of red-tape. Employee morale must be off-the-charts!

j / k navigate · click thread line to collapse