undefined | Better HN

0 pointssytse11y ago0 comments

Can you link to the merge request you refer to? Merging something depends on the quality of the implementation and the use case. We don't say that git hooks will be EE forever and we try so evaluate each merge request on its merits.

0 comments

y0ghur7_xxx11y ago

> We don't say that git hooks will be EE forever and we try so evaluate each merge request on its merits.

Seems like you sad exactly that a while ago:

"We are unlikely to merge this functionality in CE because there already is a nice implementation in EE."¹

It's your repo. You can do whatever you want with it, no need to merge PR for features that are already in your EE edition. That's why I hope someone forks it, or something better comes around.

¹https://github.com/gitlabhq/gitlabhq/pull/6883#issuecomment-...

sytseOP11y ago

Thanks for the link. In the lines before the quote I said "This PoC still leaves a lot of work. Right now the controller writes files, this should be done though gitlab-shell."

We where unlikely to merge it because the code quality was low, if someone makes a good implementation we're more open to merging it.

BTW The pull request in question uses the git hooks to do code linting. I think it is a better user experience to do this in GitLab CI in parallel with the rest of your tests https://about.gitlab.com/gitlab-ci/

y0ghur7_xxx11y ago

> We where unlikely to merge it because the code quality was low

Oh, so it's not because "there already is a nice implementation in EE." Ok.

It's also in disagreement with what you sad on the EE announcement:

"If the community develops code for a feature that is already in EE we will certainly consider merging it or open sourcing the EE feature. This depends on several factors including the seriousness of the merge request, the number of GitLab users requesting this feature and if the feature is useful for small and medium size organizations."¹

For at least this particular feature the community is clearly interested (just by looking at the +1 on the github issue), but you continue to handle the CE version as "demo" software for EE. Which is ok. Just say so clearly.

¹https://about.gitlab.com/2013/07/22/announcing-gitlab-enterp...

2 more replies

j / k navigate · click thread line to collapse

0 comments

y0ghur7_xxx11y ago

> We don't say that git hooks will be EE forever and we try so evaluate each merge request on its merits.

Seems like you sad exactly that a while ago:

"We are unlikely to merge this functionality in CE because there already is a nice implementation in EE."¹

It's your repo. You can do whatever you want with it, no need to merge PR for features that are already in your EE edition. That's why I hope someone forks it, or something better comes around.

¹https://github.com/gitlabhq/gitlabhq/pull/6883#issuecomment-...

sytseOP11y ago

Thanks for the link. In the lines before the quote I said "This PoC still leaves a lot of work. Right now the controller writes files, this should be done though gitlab-shell."

We where unlikely to merge it because the code quality was low, if someone makes a good implementation we're more open to merging it.

y0ghur7_xxx11y ago

> We where unlikely to merge it because the code quality was low

Oh, so it's not because "there already is a nice implementation in EE." Ok.

It's also in disagreement with what you sad on the EE announcement:

¹https://about.gitlab.com/2013/07/22/announcing-gitlab-enterp...

2 more replies

j / k navigate · click thread line to collapse