That's an interesting ethical question. At what point is it ok for someone who got paid by the government to do a job ok to make extra money because of that fact.
These days most Presidents get to write books about their time in the White House and make money. Buzz Aldrin still goes to cons and signs autographs for money.
So where does the line belong?
The point of allowing astronauts to bring personal items was to help keep their mental health stable and morale high over the course of an 8+ day journey in a very confined space under extreme stress. Having crew members thinking about how their side hustle was going to pan out when they got home would be a distraction and not in line with the goal of the personal item allocation.
Additionally, if it was left unchecked then future astronauts would have had to choose between bringing a picture of their loved ones or passing up on a financial bonus which would have led to a bad situation.
I can see why NASA cracked down on it pretty aggressively.
While 400 stamps don't weigh a lot, they'd still cost more than $1 each to launch by my back of the envelope calculations. You're effectively footing NASA with a $500 bill to pocket $21k.
So was that wrong? They opted to take those instead of other personal items.
Oh wait...
https://en.m.wikipedia.org/wiki/Lincoln_Bedroom_for_contribu...
It's more like your work giving you written permission for a free 1RU of space and 2 amps of power and a DIA feed described for a personal test/development/project server, you installing a personally owned 1RU server in it and doing something useful with it, and then your work trying to claim the revenue from it.
1. After the job is over and they retire 2. By making personal appearances or writing a book
Presidents generally don't take mementos on official state trips so they can sell them on eBay when they get back.
Also of interest are the "insurance covers" signed by Apollo 11 astronauts as a form of life insurance and mentioned in a linked Wikipedia article.
These covers didn't make it to the moon, but they flew on the shuttle and were officially sanctioned.
They are a plentiful and inexpensive piece of history - you can get them on ebay for about $20 (search for "STS-8 cover" or similar)
The article's talk page actually has a similar discussion over whether to call them stamps or covers in the title, so although they come down on your side its hardly a given.
Which made me realize how little I've ever used the postal services for actual letters in my life. My generation (late 80s / early 90s) must be one of the last to interact with the postal system when personally sending letters to people, rather than just parcels.
Davis Scott had handled himself superbly during his two previous flights, and Apollo 15 was in all relevant respects a huge success, most visibly so for premiering the lunar rover and bringing back the genesis rock.
> smuggling
Taking something personal in the space assigned for personal use is not smuggling.
> schlocky trinkets
Envelopes from space are pretty neat and evidently highly valued by the people that ended up buying them. Those people now have something that is nearly unique and very special to them. Have you personally ever created or done something as meaningful for other people?
> national significance
No doubt. But how come a government bureaucracy like NASA can't make cool memorabilia like that to give to the fans that payed for all of it but can only watch?
> international spotlight
Few people cared about Apollo 15. It's actually already legendary how hard the public interest dropped off after the first few landings.
> triumph of capitalism
It is a triumph, absolutely. Hundreds of people got something really meaningful for them that they would not have gotten otherwise. The astronauts got a well earned pay off. Humanity got artifacts that will be preserved down the ages. Nobody was hurt or exploited. Win Win Win all around